nx-libs/nxcomp/src/Loop.cpp, branch 3.5.99.13 NXv3 (redistributed) https://isbjoern.arctica-project.org/nx-libs/atom?h=3.5.99.13 2017-12-29T01:31:27+00:00 nxcomp: drop strncpy in favour of snprintf 2017-12-29T01:31:27+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-28T10:19:44+00:00 urn:sha1:6e98e35cf24016c9789be26d33d918f6e0e3c9a1 with very few exceptions which require careful thinking ;-) Loop.cpp: fix memleak happening with unknown tcp host 2017-12-29T01:31:27+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T20:13:39+00:00 urn:sha1:9e8bd2e1b6029ef04dec424fefcdf8842a0daf0f ==28424== 6 bytes in 1 blocks are definitely lost in loss record 1 of 7 ==28424== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28424== by 0x541D4D9: strndup (strndup.c:43) ==28424== by 0x4E8AD4B: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:311) ==28424== by 0x4EBE9CC: ConnectToRemote(ChannelEndPoint&) (Loop.cpp:6656) ==28424== by 0x4EB0A4C: SetupProxyConnection() (Loop.cpp:3205) ==28424== by 0x4EDC81A: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) (Loop.cpp:14308) ==28424== by 0x4EAE40F: NXTransPrepare (Loop.cpp:2576) ==28424== by 0x4EAA801: NXTransContinue (Loop.cpp:1610) ==28424== by 0x4EB50C9: WaitCleanup() (Loop.cpp:4436) ==28424== by 0x4EA9507: NXTransProxy (Loop.cpp:1235) ==28424== by 0x400B2A: main (Main.c:111) ChannelEndPoint.cpp: fix possible memleak in getUnixPath() 2017-12-29T01:31:26+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T18:16:15+00:00 urn:sha1:ce293647d5a63726c05260ca0e0f65a50e604ebb ChannelEndPoint.cpp: fix another memleak 2017-12-29T01:31:26+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T16:06:43+00:00 urn:sha1:eae64c4a4282eb2b511ba11c6db51d00a3b49833 ==7689== 50 bytes in 5 blocks are definitely lost in loss record 1 of 2 ==7689== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==7689== by 0x54074D9: strndup (strndup.c:43) ==7689== by 0x4E7D803: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:309) ==7689== by 0x4EC9D93: ConnectToRemote(ChannelEndPoint&) [clone .constprop.144] (Loop.cpp:6660) ==7689== by 0x4ECB94E: SetupProxyConnection() (Loop.cpp:3204) ==7689== by 0x4ECE824: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) [clone .isra.129] (Loop.cpp:14312) ==7689== by 0x4ED0F8A: NXTransPrepare (Loop.cpp:2575) ==7689== by 0x4ED1C35: NXTransContinue (Loop.cpp:1609) ==7689== by 0x4ED1D7B: WaitCleanup() (Loop.cpp:4440) ==7689== by 0x4ED2343: NXTransProxy (Loop.cpp:1234) ==7689== by 0x400B2A: main (Main.c:111) nxcomp: implement correct length handling for unix socket structs 2017-12-29T01:31:26+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T13:53:58+00:00 urn:sha1:6198e0376f9ce8130af3294fa284659f0055610d (partially) fixes ArcticaProject/nx-libs#612 Loop.cpp: drop ugly ifdef indentation 2017-12-29T01:31:26+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T13:43:50+00:00 urn:sha1:2367fc714843fa0c19778e5a8e100c5f116255ee Loop.cpp: create xServerAddrUNIX only if required 2017-12-29T01:31:26+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T13:43:22+00:00 urn:sha1:6d8fe661eb792ff9527d78073e361bb67c3b0ede Loop.cpp: improve/fix usage of s(n)printf 2017-12-29T01:31:26+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T12:16:35+00:00 urn:sha1:14a5589186c7cf0ececadedecd3db3125466d22a Loop.cpp: some reformatting/simplification/FIXMEs 2017-12-29T01:31:26+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T12:09:25+00:00 urn:sha1:3066195d79f5f24f99483d29e2489a91c9251d73 (partially) fixes ArcticaProject/nx-libs#612 Loop.cpp: delete passed object prior to overwriting it 2017-12-29T01:31:26+00:00 Ulrich Sibiller uli42@gmx.de 2017-12-27T11:54:30+00:00 urn:sha1:c31c54c1b65080b7e68942e8b50dc88b5ce1279b